From: Daniel García Moreno <daniel@endlessm.com>
Date: Thu, 10 Sep 2020 14:30:15 +0000 (+0200)
Subject: appDisplay: Don't iterate over all pages in page manager
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~655^2^2~34
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=92d3c6e051958b31151bf9538205a71cab6f70d7;p=gnome-shell.git

appDisplay: Don't iterate over all pages in page manager

In getAppPosition it's not needed to continue looking for an app in the
page manager if the app is found in a page.

This patch breaks the search loop just after the first ocurrence is
found.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1434
---

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index cecf6d185..68fdbdd0e 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -851,11 +851,11 @@ var PageManager = GObject.registerClass({
         for (let pageIndex = 0; pageIndex < this._pages.length; pageIndex++) {
             const pageData = this._pages[pageIndex];
 
-            if (!(appId in pageData))
-                continue;
-
-            page = pageIndex;
-            position = pageData[appId].position;
+            if (appId in pageData) {
+                page = pageIndex;
+                position = pageData[appId].position;
+                break;
+            }
         }
 
         return [page, position];